Do you see the "bug"? No one else did! The original author only noticed the
problem when linking to this page years later. This code is kind of dubious
because abusing the iterator pointers to be _counters_ makes them unaligned!
Our _one job_ when using ZSTs is to keep pointers aligned! _forehead slap_
because abusing the iterator pointers to be *counters* makes them unaligned!
Our *one job* when using ZSTs is to keep pointers aligned! *forehead slap*
Raw pointers don't need to be aligned at all times, so the basic trick of
using pointers as counters is _fine_, but they _should_ definitely be aligned
when passed to `ptr::read`! This is _possibly_ needless pedantry
because `ptr::read` is a noop for a ZST, but let's be a _little_ more
using pointers as counters is *fine*, but they *should* definitely be aligned
when passed to `ptr::read`! This is *possibly* needless pedantry
because `ptr::read` is a noop for a ZST, but let's be a *little* more
responsible and read from `NonNull::dangling` on the ZST path.
(Alternatively you could call `read_unaligned` on the ZST path. Either is fine,
@ -169,7 +166,6 @@ because either way we're making up a value from nothing and it all compiles
to doing nothing.)
<!-- ignore: simplified code -->
```rust,ignore
impl<T> Iterator for RawValIter<T> {
type Item = T;
@ -219,6 +215,8 @@ impl<T> DoubleEndedIterator for RawValIter<T> {
And that's it. Iteration works!
And that's it. Iteration works!
One last thing that we need to take into account, is that now when our vec gets dropped it deallocates the memory that was allocated during the time our vec was alive. With ZSTs we did not allocate any memory, and infact we never do. So right now we have unsoundness in our code where we still try deallocate a `NonNull::dangling()` ptr that we use to simulate the ZST in our vec, This means that we would cause an undefined behaviour if we try to deallocate something that we never allocated (obviously and for the right reasons). Lets fix tha, in our raw_vec we are going to tweak our Drop trait and check that we deallocate only types that are sized.